Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️1️⃣2️⃣ ir_config_parameter_multi_company #683

Merged
merged 3 commits into from
Nov 20, 2018
Merged

⬆️1️⃣2️⃣ ir_config_parameter_multi_company #683

merged 3 commits into from
Nov 20, 2018

Conversation

KolushovAlexandr
Copy link

No description provided.

Ramil-Mukhametzyanov
Ramil-Mukhametzyanov suggested changes Nov 15, 2018
View reviewed changes
Copy link

@Ramil-Mukhametzyanov Ramil-Mukhametzyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurs if I try to create a new parameter in System Parameters

yelizariev
yelizariev approved these changes Nov 16, 2018
View reviewed changes
Copy link
Collaborator

@yelizariev yelizariev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine

@yelizariev
Copy link
Collaborator 

Traceback (most recent call last):
`   File "/home/travis/build/it-projects-llc/misc-addons/ir_config_parameter_multi_company/tests/test_base.py", line 37, in test_cache
`     self.assertEqual(self.config_param.get_param(KEY), VALUE1)
` AssertionError: 'value2' != 'value1'
` - value2
` ?      ^
` + value1
` ?      ^
` 
FAILED

@yelizariev
Copy link
Collaborator 


2018-11-16 09:59:04,511 4780 INFO openerp_test odoo.addons.web_website.tests.test_website_dependent: Default, company-specific and website-specific values, record test.website_dependent(6,)
2018-11-16 09:59:04,612 4780 WARNING openerp_test odoo.models: Comparing apples and oranges: res.users(1,) == 1 (/home/travis/odoo-11.0/odoo/models.py:4708)

Ramil-Mukhametzyanov
Ramil-Mukhametzyanov approved these changes Nov 16, 2018
View reviewed changes
Copy link

@Ramil-Mukhametzyanov Ramil-Mukhametzyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@yelizariev yelizariev merged commit 5529f83 into itpp-labs:12.0 Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelizariev yelizariev yelizariev approved these changes

@Ramil-Mukhametzyanov Ramil-Mukhametzyanov Ramil-Mukhametzyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KolushovAlexandr @yelizariev @Ramil-Mukhametzyanov